[webkit-reviews] review requested: [Bug 118359] [ATK] Do not expose '\n' for wrapped lines with ATK_TEXT_BOUNDARY_CHAR : [Attachment 206007] Patch proposal plus new Unit test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 3 09:37:04 PDT 2013


Mario Sanchez Prada <mario at webkit.org> has asked  for review:
Bug 118359: [ATK] Do not expose '\n' for wrapped lines with
ATK_TEXT_BOUNDARY_CHAR
https://bugs.webkit.org/show_bug.cgi?id=118359

Attachment 206007: Patch proposal plus new Unit test
https://bugs.webkit.org/attachment.cgi?id=206007&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
Here's the patch. It's as simple as removing the specific code I added some
weeks ago by mistake, believing it was the expected behaviour (which today I
double checked that it is NOT).

Anyway, the most important part of the patch IMHO is the unit test which should
help avoiding these issues in the future, and which also helped me find another
bug in GAIL.


More information about the webkit-reviews mailing list