[webkit-reviews] review granted: [Bug 118352] [WK2][GTK] Invalid ASSERTs in WebResources loading code : [Attachment 205992] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 3 04:58:49 PDT 2013


Carlos Garcia Campos <cgarcia at igalia.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 118352: [WK2][GTK] Invalid ASSERTs in WebResources loading code
https://bugs.webkit.org/show_bug.cgi?id=118352

Attachment 205992: Patch
https://bugs.webkit.org/attachment.cgi?id=205992&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205992&action=review


You are absolutely right, but I'm not sure about the second assert. Thanks!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:-1632
> -    ASSERT(priv->loadingResourcesMap.contains(resourceIdentifier));

I'm not sure about this one, this method is always called after
webkitWebViewGetLoadingWebResource() only when we have a valid pointer.


More information about the webkit-reviews mailing list