[webkit-reviews] review denied: [Bug 118306] [WTR] Should dump as text when the mimetype is text/plain : [Attachment 205918] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 3 05:01:04 PDT 2013


Christophe Dumez <dchris at gmail.com> has denied Peter Gal
<galpeter at inf.u-szeged.hu>'s request for review:
Bug 118306: [WTR] Should dump as text when the mimetype is text/plain
https://bugs.webkit.org/show_bug.cgi?id=118306

Attachment 205918: patch
https://bugs.webkit.org/attachment.cgi?id=205918&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205918&action=review


Please unskip tests in the same patch.

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:876
> +    WTF::String mimeType =
toWTFString(adoptWK(WKBundleFrameCopyMIMETypeForResourceWithURL(frame,
WKBundleFrameCopyURL(frame))));

This is leaking the return value of WKBundleFrameCopyURL().

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:877
> +    if (url.find("dumpAsText/") != WTF::notFound || mimeType ==
"text/plain")

Don't you mean "&& mimeType != "text/plain" ?


More information about the webkit-reviews mailing list