[webkit-reviews] review denied: [Bug 118057] [CSS-Regions] OverrideLogicalHeight used by both regions and flexbox : [Attachment 205798] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Catalin badea <badea at adobe.com>'s
request for review:
Bug 118057: [CSS-Regions] OverrideLogicalHeight used by both regions and
flexbox
https://bugs.webkit.org/show_bug.cgi?id=118057

Attachment 205798: Patch
https://bugs.webkit.org/attachment.cgi?id=205798&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205798&action=review


Looks fine. Minor quibble.

> Source/WebCore/rendering/RenderRegion.cpp:58
> +    , m_computedAutoHeight(0)
> +    , m_hasComputedAutoHeight(false)

I would flip these.

> Source/WebCore/rendering/RenderRegion.h:214
> +    LayoutUnit m_computedAutoHeight;
> +    bool m_hasComputedAutoHeight : 1;

I would flip these to put m_hasComputedAutoHeight with the other bits.