[webkit-reviews] review denied: [Bug 18305] Border drawing incorrect when using both border-collapse: collapse and overflow: hidden on a table : [Attachment 205318] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 1 12:28:08 PDT 2013


Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 18305: Border drawing incorrect when using both border-collapse: collapse
and overflow: hidden on a table
https://bugs.webkit.org/show_bug.cgi?id=18305

Attachment 205318: Patch
https://bugs.webkit.org/attachment.cgi?id=205318&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205318&action=review


r-

> Source/WebCore/rendering/RenderTable.cpp:672
> +	       info.context->restore();
> +	       info.context->save();

This code seems to be making the assumption that the last save() you did pushed
only the overflow clip? That seems like a bogus assumption.


More information about the webkit-reviews mailing list