[webkit-reviews] review granted: [Bug 107579] REGRESSION(r140231): media track layout tests crashing : [Attachment 185635] Proposed fix 0.5

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Dima Gorbik
<dgorbik at apple.com>'s request for review:
Bug 107579: REGRESSION(r140231): media track layout tests crashing
https://bugs.webkit.org/show_bug.cgi?id=107579

Attachment 185635: Proposed fix 0.5
https://bugs.webkit.org/attachment.cgi?id=185635&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185635&action=review


> Source/WebCore/html/track/WebVTTParser.cpp:357
> +    switch (token.name().size()) {
> +    case 1:
> +	   if (token.name()[0] == 'c')
> +	       return WebVTTNodeTypeClass;
> +	   if (token.name()[0] == 'v')
> +	       return WebVTTNodeTypeVoice;
> +	   if (token.name()[0] == 'b')
> +	       return WebVTTNodeTypeBold;
> +	   if (token.name()[0] == 'i')
> +	       return WebVTTNodeTypeItalic;
> +	   if (token.name()[0] == 'u')

Nit: this function does a lot of "token.name()". I would be cleaner to put the
token name into a local variable.