[webkit-reviews] review denied: [Bug 108478] Web Inspector: show cursor location in DTE : [Attachment 185773] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 31 06:59:06 PST 2013


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 108478: Web Inspector: show cursor location in DTE
https://bugs.webkit.org/show_bug.cgi?id=108478

Attachment 185773: Patch
https://bugs.webkit.org/attachment.cgi?id=185773&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185773&action=review


> Source/WebCore/inspector/front-end/SourceFrame.js:66
> +    this._sourcePositionElement.addStyleClass("source-position");

.className = "source-frame-position"

> Source/WebCore/inspector/front-end/SourceFrame.js:640
> +	       this._sourcePositionElement.textContent = "Line " +
(textRange.endLine + 1) + ", Column " + (textRange.endColumn + 1);

= WebInspector.UIString("Line %d, Column %d, line, column);

> Source/WebCore/inspector/front-end/SourceFrame.js:647
> +	       text = (textRange.endLine - textRange.startLine + 1) + " lines,
" + text;

ditto


More information about the webkit-reviews mailing list