[webkit-reviews] review granted: [Bug 108334] [chromium] move remaining resource load related methods to TestRunner library : [Attachment 185477] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 108334: [chromium] move remaining resource load related methods to
TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=108334

Attachment 185477: Patch
https://bugs.webkit.org/attachment.cgi?id=185477&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185477&action=review


> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:410
> +	   return WebTestProxyBase::cannotHandleRequestError(frame, request);

There's no call to Base here?

> Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:772
> +    return !url.SchemeIs("spaceballs");

I probably would have combined this line with 769.