[webkit-reviews] review granted: [Bug 107674] [V8] Reduce usage of deprecatedV8String() and deprecatedV8Integer() : [Attachment 185469] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 107674: [V8] Reduce usage of deprecatedV8String() and deprecatedV8Integer()
https://bugs.webkit.org/show_bug.cgi?id=107674

Attachment 185469: Patch
https://bugs.webkit.org/attachment.cgi?id=185469&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185469&action=review


> Source/WebCore/bindings/v8/ScriptProfiler.cpp:62
> -    v8::CpuProfiler::StartProfiling(v8String(title,
v8::Isolate::GetCurrent()));
> +    v8::CpuProfiler::StartProfiling(v8String(title, state ? state->isolate()
: v8::Isolate::GetCurrent()));

So state can be zero here but not in stop() ?