[webkit-reviews] review requested: [Bug 108338] Add a StringTypeAdapter for ASCIILiteral : [Attachment 185520] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 30 10:47:01 PST 2013
Christophe Dumez <dchris at gmail.com> has asked for review:
Bug 108338: Add a StringTypeAdapter for ASCIILiteral
https://bugs.webkit.org/show_bug.cgi?id=108338
Attachment 185520: Patch
https://bugs.webkit.org/attachment.cgi?id=185520&action=review
------- Additional Comments from Christophe Dumez <dchris at gmail.com>
Take Darin's comments into consideration:
- Inline remaining operator+ functions
- Remove '* sizeof(LChar)' in memcpy
Note that I'm still passing the ASCIILiteral object by value based on my
earlier comment. Benjamin can hopefully confirm that he is did this on purpose.
More information about the webkit-reviews
mailing list