[webkit-reviews] review canceled: [Bug 108338] Add a StringTypeAdapter for ASCIILiteral : [Attachment 185489] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 10:47:01 PST 2013


Christophe Dumez <dchris at gmail.com> has canceled Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 108338: Add a StringTypeAdapter for ASCIILiteral
https://bugs.webkit.org/show_bug.cgi?id=108338

Attachment 185489: Patch
https://bugs.webkit.org/attachment.cgi?id=185489&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
Take Darin's comments into consideration:
- Inline remaining operator+ functions
- Remove '* sizeof(LChar)' in memcpy

Note that I'm still passing the ASCIILiteral object by value based on my
earlier comment. Benjamin can hopefully confirm that he is did this on purpose.


More information about the webkit-reviews mailing list