[webkit-reviews] review denied: [Bug 107701] Canvas and DOM go out of sync : [Attachment 185509] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied sugoi at chromium.org's
request for review:
Bug 107701: Canvas and DOM go out of sync
https://bugs.webkit.org/show_bug.cgi?id=107701

Attachment 185509: Patch
https://bugs.webkit.org/attachment.cgi?id=185509&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185509&action=review


> Source/WebCore/page/FrameView.cpp:1197
> -	   layer = root->enclosingLayer();
> +	   layer = document->renderer()->enclosingLayer();

This is wrong.

You want layer = root->enclosingLayer()->enclosingStackingContainer().

> LayoutTests/ChangeLog:11
> +	   * fast/canvas/canvas-overflow-hidden-animation.html: Added.

This test is not automatic or self-testing. It needs to detect the incorrect
condition without the patch (either with some self-check, or by comparing
against a reference).