[webkit-reviews] review denied: [Bug 108263] formMethod to have empty string as default value and 'get' as invalid. : [Attachment 185354] proposed_patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 108263: formMethod to have empty string as default value and 'get' as
invalid.
https://bugs.webkit.org/show_bug.cgi?id=108263

Attachment 185354: proposed_patch
https://bugs.webkit.org/attachment.cgi?id=185354&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=185354&action=review


Looks OK, but needs a little improvement.

> Source/WebCore/html/HTMLFormControlElement.cpp:90
> +    String formMethod = fastGetAttribute(formmethodAttr);

The result of fastGetAttribute is const AtomicString&, not String. Putting it
in a String creates unnecessary reference count churn.

> Source/WebCore/html/HTMLFormControlElement.cpp:92
> +	   return "";

The efficient way to return an empty string is emptyString(). Returning "" will
result in extra code including a call to strlen.