[webkit-reviews] review granted: [Bug 106868] DFG should not use a graph that is a vector, Nodes shouldn't move after allocation, and we should always refer to nodes by Node* : [Attachment 185127] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 28 19:08:42 PST 2013


Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 106868: DFG should not use a graph that is a vector, Nodes shouldn't move
after allocation, and we should always refer to nodes by Node*
https://bugs.webkit.org/show_bug.cgi?id=106868

Attachment 185127: the patch
https://bugs.webkit.org/attachment.cgi?id=185127&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Could you remove DFG::Allocator::free ? Also wonder if we should make
DFG::Allocator require T have a member that shows we know it's safe w.r.t
DFG::Allocator, but that's not necessary for this patch.


More information about the webkit-reviews mailing list