[webkit-reviews] review denied: [Bug 107998] Drag and drop events should be forwarded to HTML embedded with object tag. : [Attachment 185087] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 107998: Drag and drop events should be forwarded to HTML embedded with
object tag.
https://bugs.webkit.org/show_bug.cgi?id=107998

Attachment 185087: Patch
https://bugs.webkit.org/attachment.cgi?id=185087&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=185087&action=review


Compatibility with IE and Firefox seems to be a decent reason for this. Did you
consider contacting WhatWG to make this explicit in spec?

It's not OK to return true from a function named "targetIsFrame" when target is
not frame. 

Since this is a theoretical issue that is not known to affect sites, this is
very low priority, and I will not try to come up with suggestions. Please make
a patch that does not degrade WebKit code quality by making functions things
that are different from what they say.

> Source/WebCore/page/EventHandler.cpp:1918
> +    // For <object>, we only consider it a valid frame to forward DnD events
to if frame is
> +    // non-null. Unfortunately, frame will also be null if <object> has an
invalid source; in that

"targetIsFrame" is a generic function name, so it's not right to explain its
behavior by drag and drop requirements. If it's tailored to drag and drop only,
its name should say so.

Also, "DnD" is not the kind of abbreviation that is welcome in WebKit code
base.