[webkit-reviews] review denied: [Bug 107441] Web Inspector: [Network] Add cookie column to show presence of request/response cookies. : [Attachment 184724] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 28 01:15:57 PST 2013


Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 107441: Web Inspector: [Network] Add cookie column to show presence of
request/response cookies.
https://bugs.webkit.org/show_bug.cgi?id=107441

Attachment 184724: Patch
https://bugs.webkit.org/attachment.cgi?id=184724&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184724&action=review


> Source/WebCore/inspector/front-end/NetworkPanel.js:378
> +	   filterBarElement.createChild("div", "scope-bar-divider");

Please extract this change.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1124
> +		   row.enableStyleClass("offscreen", !rowIsVisible);

ditto


More information about the webkit-reviews mailing list