[webkit-reviews] review denied: [Bug 107951] Web Inspector: [Canvas] support instrumenting canvases in iframes (backend side) : [Attachment 184750] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 107951: Web Inspector: [Canvas] support instrumenting canvases in iframes
(backend side)
https://bugs.webkit.org/show_bug.cgi?id=107951

Attachment 184750: Patch
https://bugs.webkit.org/attachment.cgi?id=184750&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184750&action=review


> Source/WebCore/inspector/Inspector.json:3382
> +		   "name": "frameWithCanvases",

Consider renaming - event should tell us what exactly is happening

> Source/WebCore/inspector/InspectorCanvasAgent.cpp:132
> +	       if (m_framesWithUninstrumentedCanvases.contains(frame)) {

What if the frame was destroyed and re-created at same address? You should
track frame's lifetime and make a cleanup.

> Source/WebCore/inspector/InspectorCanvasAgent.cpp:190
> +    InjectedScriptCanvasModule module =
injectedScriptCanvasModule(errorString, traceLogId);

This nice refactoring seems to be a separate change.