[webkit-reviews] review granted: [Bug 108033] JSC: FunctionParameters are memory hungry. : [Attachment 184916] Proposed patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 108033: JSC: FunctionParameters are memory hungry.
https://bugs.webkit.org/show_bug.cgi?id=108033

Attachment 184916: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=184916&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184916&action=review


> Source/JavaScriptCore/parser/Nodes.cpp:161
> +    void* slot = WTF::fastMalloc(objectSize);

Again with the WTF::  (Do you need it?)

>> Source/JavaScriptCore/parser/Nodes.cpp:171
>> +	for (ParameterNode* parameter = firstParameter; parameter; parameter =
parameter->nextParam()) {
>> +	    new (&identifiers()[i++]) Identifier(parameter->ident());
>> +	}
> 
> One line control clauses should not use braces.  [whitespace/braces] [4]

No need for braces here.