[webkit-reviews] review granted: [Bug 108029] JSC: SourceProviderCache is memory hungry. : [Attachment 184912] Proposed patch v2

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 108029: JSC: SourceProviderCache is memory hungry.
https://bugs.webkit.org/show_bug.cgi?id=108029

Attachment 184912: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=184912&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184912&action=review


> Source/JavaScriptCore/parser/SourceProviderCacheItem.h:92
> +    ~SourceProviderCacheItem();

This is more common near the top of the class.

> Source/JavaScriptCore/parser/SourceProviderCacheItem.h:110
> +    void* slot = WTF::fastMalloc(objectSize);

I don't think the WTF:: here is needed.