[webkit-reviews] review denied: [Bug 107975] Don't use the threaded HTML parser for javascript: URLs : [Attachment 184792] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 107975: Don't use the threaded HTML parser for javascript: URLs
https://bugs.webkit.org/show_bug.cgi?id=107975

Attachment 184792: Patch
https://bugs.webkit.org/attachment.cgi?id=184792&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184792&action=review


> Source/WebCore/html/parser/HTMLDocumentParser.cpp:185
> +    return m_options.useThreading && !isParsingFragment() &&
!document()->url().isBlankURL();

We should put this logic in HTMLParserOptions so that m_options reflects
reality.

IMHO, disabling threading for blank URLs makes sense.  Given that we've wanted
to do this twice, it's probably the right thing to do.