[webkit-reviews] review denied: [Bug 107985] [chromium] Export ResourceRequest's priority through WebURLRequest : [Attachment 184814] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 25 17:19:26 PST 2013


Adam Barth <abarth at webkit.org> has denied James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 107985: [chromium] Export ResourceRequest's priority through WebURLRequest
https://bugs.webkit.org/show_bug.cgi?id=107985

Attachment 184814: Patch
https://bugs.webkit.org/attachment.cgi?id=184814&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184814&action=review


> Source/WebCore/platform/chromium/support/WebURLRequest.cpp:329
> +    switch (m_private->m_resourceRequest->priority()) {

We usually just use a static_cast rather than a switch.  Also, we use
AssertMatchignEnums.cpp to make sure that the WebCore enums stay in sync with
the API enums.


More information about the webkit-reviews mailing list