[webkit-reviews] review denied: [Bug 73482] sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision. : [Attachment 181646] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 73482: sheriffbot roll-chromium-deps shouldn't create a bug with None as
the new revision.
https://bugs.webkit.org/show_bug.cgi?id=73482

Attachment 181646: Patch
https://bugs.webkit.org/attachment.cgi?id=181646&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181646&action=review


Otherwise this is good to go.

> Tools/Scripts/webkitpy/tool/steps/updatechromiumdeps.py:48
> +    @staticmethod
> +    def _parse_revision_name(revision):

Please write a test for this.