[webkit-reviews] review denied: [Bug 107426] [CoordinatedGraphics] CSS sticky elements are blinking while scrolling : [Attachment 184434] patch v2

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied  review:
Bug 107426: [CoordinatedGraphics] CSS sticky elements are blinking while
scrolling
https://bugs.webkit.org/show_bug.cgi?id=107426

Attachment 184434: patch v2
https://bugs.webkit.org/attachment.cgi?id=184434&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184434&action=review


I suggest asking Simon for a review.

> Source/WebKit2/ChangeLog:14
> +	   Set scroll position delta for sticky elements if the they are
> +	   located out of their in-flow layout position (when they have
actually stuck). 
> +
> +	   * UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
> +	   (WebKit::LayerTreeRenderer::setLayerState):
> +	   *
WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
> +	   (WebKit::updateOffsetFromViewportForSelf):

This does not explain the patch in the slightest.

You should give some context about why the bug (CSS sticky elements are
blinking while scrolling) was happening. This helps the reader evaluate the
fix.