[webkit-reviews] review denied: [Bug 107630] Implement MouseEvent constructor : [Attachment 184158] Fixed mac failures. Review?

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kentaro Hara <haraken at chromium.org>'s
request for review:
Bug 107630: Implement MouseEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=107630

Attachment 184158: Fixed mac failures. Review?
https://bugs.webkit.org/attachment.cgi?id=184158&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184158&action=review


> Source/WebCore/bindings/v8/Dictionary.cpp:473
> +	   // FIXME: When EventTarget is an interface and not a mixin, fix
V8Node to V8EventTarget.
> +	   v8::Handle<v8::Object> error =
wrapper->FindInstanceInPrototypeChain(V8Node::GetTemplate());

So this only works with Nodes?	Maybe we need a toEventTarget function in
WrapperTypeInfo similar to the toActiveDOMObject function.

> Source/WebCore/dom/MouseEvent.idl:35
> +    [Conditional=POINTER_LOCK]      readonly attribute long		  
webkitMovementX;
> +    [Conditional=POINTER_LOCK]      readonly attribute long		  
webkitMovementY;

These don't get InitializedByEventConstructor ?  Nor do the "extensions" below?