[webkit-reviews] review granted: [Bug 106837] [CSS Shaders] Parse @-webkit-filter : [Attachment 184004] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Max Vujovic <mvujovic at adobe.com>'s
request for review:
Bug 106837: [CSS Shaders] Parse @-webkit-filter
https://bugs.webkit.org/show_bug.cgi?id=106837

Attachment 184004: Patch
https://bugs.webkit.org/attachment.cgi?id=184004&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=184004&action=review


>
LayoutTests/css3/filters/custom/custom-filter-parsing-at-rule-invalid-expected.
txt:46
> +Unprefixed rule.
> + at filter my-filter { }
> +PASS insertRuleException instanceof DOMException is true
> +PASS insertRuleException.code is 12
> +PASS successfullyParsed is true

You already have this test.

>
LayoutTests/css3/filters/script-tests/custom-filter-parsing-at-rule-invalid.js:
20
> +    try {
> +	exception = null;
> +	    stylesheet.insertRule(rule, 0);
> +	    testFailed("\"" + rule + "\" did not throw a syntax error.");
> +    } catch (e) {
> +	insertRuleException = e;
> +	shouldBeTrue("insertRuleException instanceof DOMException");
> +	shouldEvaluateTo("insertRuleException.code", DOMException.SYNTAX_ERR)
> +    }

Nit: indentation all weird :)

>
LayoutTests/css3/filters/script-tests/custom-filter-parsing-at-rule-invalid.js:
33
> +testInvalidFilterAtRule("Unprefixed rule.", "@filter my-filter { }");

Here is the dupe.

> Source/WebCore/ChangeLog:41
> +	   (WebCore):

Remove this line.

> Source/WebCore/ChangeLog:57
> +	   (WebCore):

Ditto.

> Source/WebCore/ChangeLog:66
> +	   (WebCore):

Ditto.

> Source/WebCore/ChangeLog:76
> +	   (WebCore):

Ditto.

> Source/WebCore/ChangeLog:87
> +	   (WebCore):

Ditto.