[webkit-reviews] review denied: [Bug 9221] resize property doesn't work on iframes : [Attachment 184113] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 22:05:48 PST 2013


Eric Seidel <eric at webkit.org> has denied Christian Biesinger
<cbiesinger at chromium.org>'s request for review:
Bug 9221: resize property doesn't work on iframes
https://bugs.webkit.org/show_bug.cgi?id=9221

Attachment 184113: Patch
https://bugs.webkit.org/attachment.cgi?id=184113&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184113&action=review


Looks like we need another round for style and for the 2 tests it fails.

> Source/WebCore/rendering/RenderBlock.cpp:2770
> +    const PaintPhase phase = paintInfo.phase;

We don't use const like this.  const& sure, but we don't generally use const
for values.


More information about the webkit-reviews mailing list