[webkit-reviews] review granted: [Bug 107459] WebKit should support decoding multi-byte entities in XML content : [Attachment 184125] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 107459: WebKit should support decoding multi-byte entities in XML content
https://bugs.webkit.org/show_bug.cgi?id=107459

Attachment 184125: Patch
https://bugs.webkit.org/attachment.cgi?id=184125&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184125&action=review


This looks good, modulo the code point / code unit naming question.  rniwa is
right that it would be better to go straight to UTF-8, but we can leave that
for a future patch.

> Source/WebCore/html/parser/HTMLEntityParser.cpp:169
> +    size_t numberOfCodePoints =
appendUChar32ToUCharArray(search.mostRecentMatch()->firstValue, result);

numberOfCodePoints -> numberOfCodeUnits, right?

> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:1182
> +    WTF::Unicode::ConversionResult conversionResult =
WTF::Unicode::convertUTF16ToUTF8(&utf16Entity,
> +	   utf16Entity + numberOfCodePoints, &target, target + 9);

Can we get this 9 as sizeof sharedXHTMLEntityResult ?