[webkit-reviews] review granted: [Bug 107612] Add monitoring of patches and queues to the QueueStatusServer : [Attachment 184126] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 22 21:58:52 PST 2013
Adam Barth <abarth at webkit.org> has granted Alan Cutter
<alancutter at chromium.org>'s request for review:
Bug 107612: Add monitoring of patches and queues to the QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=107612
Attachment 184126: Patch
https://bugs.webkit.org/attachment.cgi?id=184126&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184126&action=review
This looks good. I don't remember this code very well, so this review isn't
based on any deep knowledge of the stuff you're changing. ;)
> Tools/QueueStatusServer/loggers/recordpatchevent.py:42
> + print patches_waiting
Do we want to call print in production?
More information about the webkit-reviews
mailing list