[webkit-reviews] review denied: [Bug 107507] Adjust design of the Calendar Picker : [Attachment 184128] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 21:55:28 PST 2013


Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 107507: Adjust design of the Calendar Picker
https://bugs.webkit.org/show_bug.cgi?id=107507

Attachment 184128: Patch
https://bugs.webkit.org/attachment.cgi?id=184128&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=184128&action=review


> Source/WebCore/Resources/pagepopups/chromium/calendarPickerChromium.css:10
> +.days-area-container:focus {
> +  -webkit-transition: border-color 200ms;

wrong indentation.

> Source/WebCore/Resources/pagepopups/chromium/calendarPickerChromium.css:13
> +  border-color: rgb(77, 144, 254);

should be -webkit-focus-ring-color.
In Chromium Settings page, we respect system's focus ring color.

> Source/WebCore/Resources/pagepopups/chromium/pickerCommonChromium.css:44
> +    border-color: rgb(77, 144, 254);

should be -webkit-focus-ring-color.


More information about the webkit-reviews mailing list