[webkit-reviews] review granted: [Bug 107317] Make CompactHTMLToken a little more compact : [Attachment 183930] Updated to TOT

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 107317: Make CompactHTMLToken a little more compact
https://bugs.webkit.org/show_bug.cgi?id=107317

Attachment 183930: Updated to TOT
https://bugs.webkit.org/attachment.cgi?id=183930&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183930&action=review


I am not an expert on the parser, but the patch looks fine to me and probably
does not require parser expertise.

> Source/WebCore/ChangeLog:13
> +	   however when I tried to assert that it failed.  Presumably because
> +	   Vector<T> is more than void* in size.

Yes, Vector<T> is much more than void* in size!

> Source/WebCore/html/parser/CompactHTMLToken.h:78
>      Vector<CompactAttribute> m_attributes;

What’s the typical size of this vector? If it’s typically empty, it could be
OwnPtr<Vector>. If it typically has a small number of attributes, maybe it
should have inline capacity.