[webkit-reviews] review denied: [Bug 107044] [CSS Grid Layout] Add grid.css to hold the common grid testing code : [Attachment 183578] Proposed change 1: Added grid.css and move most files to it.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 22 10:15:36 PST 2013


Tony Chang <tony at chromium.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 107044: [CSS Grid Layout] Add grid.css to hold the common grid testing code
https://bugs.webkit.org/show_bug.cgi?id=107044

Attachment 183578: Proposed change 1: Added grid.css and move most files to it.
https://bugs.webkit.org/attachment.cgi?id=183578&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183578&action=review


> LayoutTests/fast/css-grid-layout/resources/grid.css:11
> +#a {

I think using single letter ids seems like it could cause problems and weird
side effects in the future.  Can we make these classes with descriptive names?


More information about the webkit-reviews mailing list