[webkit-reviews] review granted: [Bug 107284] [BlackBerry] Set spellchecking calculations on a timer to free up the WebKit thread : [Attachment 183463] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Nima Ghanavatian
<nghanavatian at rim.com>'s request for review:
Bug 107284: [BlackBerry] Set spellchecking calculations on a timer to free up
the WebKit thread
https://bugs.webkit.org/show_bug.cgi?id=107284

Attachment 183463: Patch
https://bugs.webkit.org/attachment.cgi?id=183463&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183463&action=review


LGTM.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.h:167
> +    void
callRequestCheckingFor(WTF::PassRefPtr<WebCore::SpellCheckRequest>);

You should not need the WTF prefix.

> Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp:81
> +    WTF::RefPtr<WebCore::Range> rangeForSpellChecking =
rangeForSpellCheckingPtr;

Ditto.