[webkit-reviews] review denied: [Bug 107112] [Gtk] [Cairo] Memory leak when is WebView destroy. : [Attachment 183386] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Oleg Smirnov
<oleg.smirnov at lge.com>'s request for review:
Bug 107112: [Gtk] [Cairo] Memory leak when is WebView destroy.
https://bugs.webkit.org/show_bug.cgi?id=107112

Attachment 183386: Patch
https://bugs.webkit.org/attachment.cgi?id=183386&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183386&action=review


> Source/WebCore/ChangeLog:11
> +	   No new tests, there is platform memory leak.
> +
> +	   Created cairo surface never then deleted, cause of factory method
> +	   createSurfaceForBackingStore for GTK backend returns incorrect
refered PassRefPtr value.

"No new test" usually goes after the change description, which could use some
rewording, I think. Something like "Make createSurfaceForBackingStore return a
smart pointer in all supported build configurations to avoid a memory leak"