[webkit-reviews] review denied: [Bug 105187] [EFL][WK2] ManualTests/window-geometry.html contents is shaking while scrolling : [Attachment 180174] preliminary patch.

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 105187: [EFL][WK2] ManualTests/window-geometry.html contents is shaking
while scrolling
https://bugs.webkit.org/show_bug.cgi?id=105187

Attachment 180174: preliminary patch.
https://bugs.webkit.org/attachment.cgi?id=180174&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180174&action=review


This is an interesting idea, but it needs good test coverage.

This raises interesting questions like how to drive this properly when you have
JavaScript and User initiated scrolling going on simultaneously.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:249
> +#if USE(TILED_BACKING_STORE)
> +    , m_scale(1)
> +#endif

WebPage already has a concept of scaleFactor. Why introduce a new scale here?
The name is also too generic given the existing support for scaling.

> Source/WebKit2/WebProcess/WebPage/WebPage.h:888
>  #if USE(TILED_BACKING_STORE)
>      WebCore::IntSize m_viewportSize;
> +    float m_scale;
>  #endif

This has nothing to do with TILED_BACKING_STORE.