[webkit-reviews] review denied: [Bug 91862] Update text upon item selection for menu lists : [Attachment 154012] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 11 23:55:43 PST 2013
Benjamin Poulain <benjamin at webkit.org> has denied Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 91862: Update text upon item selection for menu lists
https://bugs.webkit.org/show_bug.cgi?id=91862
Attachment 154012: Patch
https://bugs.webkit.org/attachment.cgi?id=154012&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
(In reply to comment #4)
> (From update of attachment 154012 [details])
> I would kinda have expected the DOM to call back to the renderer to set the
text instead of the renderer driving the whole process.
Agreed. Any reason why is setTextFromItem() not called from listBoxSelectItem?
+ How do we test this?
More information about the webkit-reviews
mailing list