[webkit-reviews] review granted: [Bug 103839] FlakyTestReporter should be re-enabled and taught how to post patches : [Attachment 181278] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 103839: FlakyTestReporter should be re-enabled and taught how to post
patches
https://bugs.webkit.org/show_bug.cgi?id=103839

Attachment 181278: Patch
https://bugs.webkit.org/attachment.cgi?id=181278&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181278&action=review


This looks great!

> Tools/ChangeLog:9
> +	   It also adds a real Port object to the EWS and CommitQueue objects

woah

> Tools/Scripts/webkitpy/tool/commands/queues.py:250
> +	   return os.path.join(self._log_directory(), "%s.log" %
patch.bug_id())

Not self._tool.filesystem.join ?

> Tools/Scripts/webkitpy/tool/commands/queues.py:273
> +	   if not self.port_name:
> +	       return

Should this assert instead?