[webkit-reviews] review granted: [Bug 105374] CSP 1.1: Experiment with adding line numbers to violation reports. : [Attachment 181277] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 105374: CSP 1.1: Experiment with adding line numbers to violation reports.
https://bugs.webkit.org/show_bug.cgi?id=105374

Attachment 181277: Patch
https://bugs.webkit.org/attachment.cgi?id=181277&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181277&action=review


> Source/WebCore/page/ContentSecurityPolicy.cpp:1616
> +	   int frameNumber = 0;
> +	   if (!stack->at(0).lineNumber() && stack->size() > 1 &&
stack->at(1).lineNumber())
> +	       frameNumber = 1;
> +
> +	   const ScriptCallFrame& callFrame = stack->at(frameNumber);

I might have made this a helper function with a descriptive frame.