[webkit-reviews] review requested: [Bug 105608] [Qt] Outmost window's content size doesn't update when inner <object> frame is expanded : [Attachment 180859] A patch make <object> element support FrameFlattening which corrently update outmost window's contentsSize & scrollbar position

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 4 03:59:45 PST 2013


Michael Brüning <michael.bruning at digia.com> has asked  for review:
Bug 105608: [Qt] Outmost window's content size doesn't update when inner
<object> frame is expanded
https://bugs.webkit.org/show_bug.cgi?id=105608

Attachment 180859: A patch make <object> element support FrameFlattening which
corrently update outmost window's contentsSize & scrollbar position
https://bugs.webkit.org/attachment.cgi?id=180859&action=review

------- Additional Comments from Michael Brüning <michael.bruning at digia.com>
I think this was meant to be set to r? instead of r+ (r? is for requesting
reviews, r+ should only be set by reviewers for reviewed/accepted patches). 

Also, it seems that the patch format is wrong, so before this can be reviewed,
please rebase the patch on top of trunk. You may consider using
./Tools/Scripts/webkit-patch upload for this as it is very convenient.


More information about the webkit-reviews mailing list