[webkit-reviews] review denied: [Bug 105014] [Qt] Horizontal scrollbars events are offseted making them difficult to use : [Attachment 181185] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Michael Brüning
<michael.bruning at digia.com>'s request for review:
Bug 105014: [Qt] Horizontal scrollbars events are offseted making them
difficult to use
https://bugs.webkit.org/show_bug.cgi?id=105014

Attachment 181185: Patch
https://bugs.webkit.org/attachment.cgi?id=181185&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181185&action=review


Good catch! I think however the fix is slightly different.

> Source/WebCore/ChangeLog:12
> +	   hte rectangle for the hit test.

hte -> the

> Source/WebCore/platform/qt/ScrollbarThemeQStyle.cpp:158
> +    opt.direction = qApp->layoutDirection();

It seems like a bug that QStyle behaves that way, but ok, what we do isn't
quite right either.

We _should_ be picking up the layout direction from the _widget_ unless
specified by the RenderStyle. Therefore I think
the correct fix is to change initGenericStyleOption in QStyleFacadeImp.cpp to
do the

    option->direction = facadeOption.direction;

initialization only if facadeOption.direction is not Auto. If it is auto, then
we should
keep what we have in option->direction, which is (commonly) initialized from
the widget's
layout direction, which comes from the QGuiApplication.