[webkit-reviews] review denied: [Bug 111066] svn-apply cannot apply patches which is generated by git to files that contain space characters in their path : [Attachment 190699] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 16:53:31 PST 2013


Daniel Bates <dbates at webkit.org> has denied Yuki Sekiguchi
<yuki.sekiguchi at access-company.com>'s request for review:
Bug 111066: svn-apply cannot apply patches which is generated by git to files
that contain space characters in their path
https://bugs.webkit.org/show_bug.cgi?id=111066

Attachment 190699: Patch
https://bugs.webkit.org/attachment.cgi?id=190699&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
We need a test for this change. See the existing tests for this function in
Tools/Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl. Run
Tools/Scripts/test-webkitperl to run the Perl unit tests.


More information about the webkit-reviews mailing list