[webkit-reviews] review denied: [Bug 110883] Add state variables to avoid OpenGL redundant state changes on GraphicsContext3D : [Attachment 190836] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Bruno Abinader
<bruno.abinader at basyskom.com>'s request for review:
Bug 110883: Add state variables to avoid OpenGL redundant state changes on
GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=110883

Attachment 190836: Patch
https://bugs.webkit.org/attachment.cgi?id=190836&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190836&action=review


Looks generally OK, but there's one bug, and one comment update needed.

> Source/WebCore/platform/graphics/GraphicsContext3D.h:1115
> +	   // might not be handled correctly on non-optimized GL drivers.

This still isn't clear. Could you please say something like:

The cached values below are used by some, but not all, ports to reduce
redundant state transitions. Do not rely on their being up-to-date in common
code.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:939

> +    if (m_state.stencilFail == fail && m_state.stencilZFail && zfail &&
m_state.stencilZPass == zpass)

m_state.stencilZFail == zfail