[webkit-reviews] review granted: [Bug 111124] RelevantRepaintedObjects heuristic should ensure there is some coverage in the bottom half of the relevant view rect : [Attachment 190828] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 111124: RelevantRepaintedObjects heuristic should ensure there is some
coverage in the bottom half of the relevant view rect
https://bugs.webkit.org/show_bug.cgi?id=111124

Attachment 190828: Patch
https://bugs.webkit.org/attachment.cgi?id=190828&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190828&action=review


> Source/WebCore/ChangeLog:12
> +	   We need two Regions now -- one for the top and another for the
bottom. Make sure 
> +	   we have at least half of our desired coverage in both.

This seems a bit western-centric. What about languages that might load a strip
down one side first?

> Source/WebCore/page/Page.cpp:1348
> +    if (topRelevantRect.intersects(snappedPaintRect))
> +	   m_topRelevantPaintedRegion.unite(snappedPaintRect);
> +    else
> +	   m_bottomRelevantPaintedRegion.unite(snappedPaintRect);

Do you want to ignore coverage over the bottom rect if the paint rect happens
to just touch the top rect?