[webkit-reviews] review granted: [Bug 108357] REGRESSION(r140907): Incorrect baseline for cells with media content during load : [Attachment 190794] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 108357: REGRESSION(r140907): Incorrect baseline for cells with media
content during load
https://bugs.webkit.org/show_bug.cgi?id=108357

Attachment 190794: Patch
https://bugs.webkit.org/attachment.cgi?id=190794&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190794&action=review


Sigh.

> Source/WebCore/rendering/RenderTableCell.cpp:255
> +    if ((va == BASELINE || va == TEXT_BOTTOM || va == TEXT_TOP || va ==
SUPER || va == SUB || va == LENGTH) && cellBaselinePosition() >
section()->rowBaseline(rowIndex())) {

This should need some helper function as it's now repeated 3 times:

va == BASELINE || va == TEXT_BOTTOM || va == TEXT_TOP || va == SUPER || va ==
SUB || va == LENGTH

Also all these case should be tested below (only BASELINE is AFAICT) or else
nothing prevents us from breaking them later on.