[webkit-reviews] review denied: [Bug 110269] Optionally partition cache to prevent using cache for tracking : [Attachment 189604] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Jeffrey Pfau
<jeffrey at endrift.com>'s request for review:
Bug 110269: Optionally partition cache to prevent using cache for tracking
https://bugs.webkit.org/show_bug.cgi?id=110269

Attachment 189604: Patch
https://bugs.webkit.org/attachment.cgi?id=189604&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189604&action=review


r- since Adam had a bunch of comments and I had one minor one. I think it's
probably ready to go once you address the current round of comments.

> Source/WTF/wtf/Platform.h:1071
> +#define WTF_USE_CACHE_PARTITIONING 1
> +#define WTF_USE_PUBLIC_SUFFIX_LIST 1

These should both be ENABLE flags, not USE. USE is about making use of a
particular external library or API, ENABLE is about optional pieces of
functionality in WebCore itself.