[webkit-reviews] review denied: [Bug 110582] [GTK] Generate UserAgentGtk.h into DerivedSources/Platform : [Attachment 189740] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 110582: [GTK] Generate UserAgentGtk.h into DerivedSources/Platform
https://bugs.webkit.org/show_bug.cgi?id=110582

Attachment 189740: Patch
https://bugs.webkit.org/attachment.cgi?id=189740&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189740&action=review


> Source/Platform/GNUmakefile.list.am:3
> +platform_built_sources += \
> +	DerivedSources/Platform/UserAgentGtk.h
> +

This is generated during configuration and not by makefile rules, so I don't
think it should be treated like a normal generated source. I think a better
change, instead of this change is to make it so that UserAgentGtk.h isn't
templatized at all. Instead we should define WEBKIT_USER_AGENT_MAJOR_VERSION in
the autotoolsconfig.h header.