[webkit-reviews] review denied: [Bug 110431] INPUT_MULTIPLE_FIELDS_UI: Unable to enter "24" to hour field : [Attachment 189503] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has denied Kunihiko
Sakamoto <ksakamoto at chromium.org>'s request for review:
Bug 110431: INPUT_MULTIPLE_FIELDS_UI: Unable to enter "24" to hour field
https://bugs.webkit.org/show_bug.cgi?id=110431

Attachment 189503: Patch
https://bugs.webkit.org/attachment.cgi?id=189503&action=review

------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189503&action=review


I have another idea.
How about adding pattern attribute to DateTimeEditElement?
In this case, we don't need to add an Internals method, and use
getElementByPseudoId(internals.youngestShadowRoot(input),
"-webkit-datetime-edit").setAttribute("pattern", "KK:mm a") (then doing
something invoking updateInnerTextValue()). Also, we don't need to add extra
data member for date/time format.

>> Source/WebCore/html/HTMLInputElement.cpp:1571
>> +	if (m_inputType->isDateField() || m_inputType->isTimeField() ||
m_inputType->isDateTimeField() || m_inputType->isDateTimeLocalField())
> 
> I think we decided not to branch depending on input types in
HTMLInputElement.cpp. setDateTimeFormat should be added to InputType.h as a
virtual method.

Keishi is right.