[webkit-reviews] review granted: [Bug 110132] Add animation class for new calendar picker : [Attachment 189491] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 110132: Add animation class for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110132

Attachment 189491: Patch
https://bugs.webkit.org/attachment.cgi?id=189491&action=review

------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189491&action=review


> Source/WebCore/ChangeLog:14
> +	   (AnimationTimingFunction.Linear): Parameter t should be a number
between 0 and 1.

Such comment should be in the code, or the code should have console.assert.

> Source/WebCore/Resources/pagepopups/calendarPicker.js:841
> +Animator.lastId = 0;

I guess this should be private.