[webkit-reviews] review granted: [Bug 110295] Transformed SVG background images can be blurry/pixelated : [Attachment 189246] Account for transform in SVG background images

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Philip Rogers <pdr at google.com>'s
request for review:
Bug 110295: Transformed SVG background images can be blurry/pixelated
https://bugs.webkit.org/show_bug.cgi?id=110295

Attachment 189246: Account for transform in SVG background images
https://bugs.webkit.org/attachment.cgi?id=189246&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189246&action=review


LGTM. Just some snippets.

> Source/WebCore/loader/cache/CachedImage.cpp:198
> +	   UNUSED_PARAM(renderer);

indentation wrong.

> Source/WebCore/svg/graphics/SVGImage.cpp:153
> +    ASSERT(imageBufferScale.width() && imageBufferScale.height());

Can you make this two asserts please?

> Source/WebCore/svg/graphics/SVGImage.cpp:159
> +    drawForContainer(buffer->context(), containerSize, zoom,
imageBufferSize, zoomedContainerRect, ColorSpaceDeviceRGB, CompositeSourceOver,
BlendModeNormal);

Aren't the last two or three options default for this function anyway? Not sure
if we should keep it or remove it.

> LayoutTests/svg/as-background-image/svg-transformed-background.html:17
> +  -ie-transform:scale(5);
> +  -ie-transform-origin:0 0;
> +  -moz-transform:scale(5);
> +  -moz-transform-origin:0 0;

This is unnecessary. please remove these.

> LayoutTests/svg/as-background-image/svg-transformed-background.html:33
> +  -ie-transform:scale(2.5, 10);
> +  -ie-transform-origin:0 0;
> +  -moz-transform:scale(2.5, 10);
> +  -moz-transform-origin:0 0;

ditto.