[webkit-reviews] review granted: [Bug 110360] [New Multicolumn] Column gap is computed incorrectly : [Attachment 189347] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 110360: [New Multicolumn] Column gap is computed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=110360

Attachment 189347: Patch
https://bugs.webkit.org/attachment.cgi?id=189347&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189347&action=review


> Source/WebCore/rendering/RenderMultiColumnSet.cpp:105
> +	   return parentBlock->style()->fontDescription().computedPixelSize();
// "1em" is recommended as the normal gap setting. Matches <p> margins.

The comment makes me think that computedPixelSize() returns a value equivalent
to 1em, which is confusing.

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:106
> +    return static_cast<int>(parentBlock->style()->columnGap());

I think this should use clampToInteger() like roundedIntPoint() etc do. Weird
that it's a float.