[webkit-reviews] review granted: [Bug 109742] CSSPreloadScanner should not depend on HTMLToken : [Attachment 188162] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 13 13:25:32 PST 2013


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 109742: CSSPreloadScanner should not depend on HTMLToken
https://bugs.webkit.org/show_bug.cgi?id=109742

Attachment 188162: Patch
https://bugs.webkit.org/attachment.cgi?id=188162&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188162&action=review


> Source/WebCore/html/parser/CSSPreloadScanner.cpp:61
> +void CSSPreloadScanner::scan(const LChar* begin, const LChar* end,
Vector<OwnPtr<PreloadRequest> >& requests)

This is just a template. :)

> Source/WebCore/html/parser/CSSPreloadScanner.h:44
> +    void scan(const LChar* begin, const LChar* end,
Vector<OwnPtr<PreloadRequest> >&);

This isn't currently used, or?


More information about the webkit-reviews mailing list